Skip to content

Removed useless Compile.programmer parameter from GRPC interface #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2020
Merged

Removed useless Compile.programmer parameter from GRPC interface #862

merged 1 commit into from
Jul 23, 2020

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jul 23, 2020

It's never used, I guess it's a leftover from previous experiments.

@rsora
Copy link
Contributor

rsora commented Jul 23, 2020

Closes #861

@cmaglie cmaglie linked an issue Jul 23, 2020 that may be closed by this pull request
[gRPC] Check whether CompileReq#programmer is required #861
Closed
@cmaglie cmaglie added this to the 0.12.0 milestone Jul 23, 2020
rsora
rsora approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@cmaglie cmaglie merged commit 3775f51 into arduino:master Jul 23, 2020
@cmaglie cmaglie deleted the remove_useless_parameter_in_compile branch July 23, 2020 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rsora rsora rsora approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.

[gRPC] Check whether CompileReq#programmer is required
2 participants
@cmaglie @rsora